Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: tomcat-dev@jakarta.apache.org
Message-ID: <D84B43C5F94DD511877400609457497C01BF64@css4.cs>
From: GOMEZ Henri <hgomez@slib.fr>
To: tomcat-dev@jakarta.apache.org
Subject: RE: Any reason why...
Date: Fri, 22 Jun 2001 10:27:15 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"

+1, I'll correct now.

I'll have a huge commit to send today, 
AJP14 login feature is quasi finished :)


-
Henri Gomez                 ___[_]____
EMAIL : hgomez@slib.fr        (. .)                     
PGP KEY : 697ECEDD    ...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 


>-----Original Message-----
>From: Andy Armstrong [mailto:andy@tagish.com]
>Sent: Friday, June 22, 2001 10:25 AM
>To: tomcat-dev@jakarta.apache.org
>Subject: Re: Any reason why...
>
>
>Andy Armstrong wrote:
>> 
>> GOMEZ Henri wrote:
>> >
>> > >...these two lines at around 1110 in jk_ajp_common.c
>> > >
>> > >  int port = jk_get_worker_port(props, p->name, port);
>> > >  char *host = jk_get_worker_host(props, p->name, host);
>> > >
>> > >use unitialised values for port and host. Anyone mind if 
>I change them
>> > >to
>> > >
>> > >  int port = jk_get_worker_port(props, p->name, -1);
>> > >  char *host = jk_get_worker_host(props, p->name, NULL);
>> > >
>> >
>> > The value are initialised some lines before depending 
>AJP13/AJP14 :)
>> 
>> They can't be initialised before -- they're actually declared in the
>> fragment I quote -- they don't exist before here.
>
>Ah. I see the real problem -- they're declared at the start of the
>function and again here. Unfortunately the values that are in 
>scope when
>jk_get_worker_port() and jk_get_worker_host() are called are the new,
>uninitialised variables rather than the ones declared at the top of the
>function.
>
>Those two lines should change to
>
>    port = jk_get_worker_port(props, p->name, port);
>    host = jk_get_worker_host(props, p->name, host);
>
>
>-- 
>Andy Armstrong, Tagish
>