Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 22934 invoked by uid 500); 22 Jun 2001 15:33:43 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: tomcat-dev@jakarta.apache.org Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 22886 invoked from network); 22 Jun 2001 15:33:41 -0000 Message-ID: <3B3365D6.E4B6DB0A@tagish.com> Date: Fri, 22 Jun 2001 16:35:50 +0100 From: Andy Armstrong Organization: Tagish Ltd X-Mailer: Mozilla 4.75 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: tomcat-dev@jakarta.apache.org CC: jean-frederic clere Subject: Re: #define JK_VERSION in j-t-c (doesn't exist) References: <3B29DA92.193D585E@tagish.com> <3B29F2D2.7D9ED0D0@fujitsu-siemens.com> <3B29F59A.5F801BE1@tagish.com> <3B2A602A.F0657EA9@fujitsu-siemens.com> <3B2A672B.9E69DD5E@tagish.com> <3B2B2E73.3C21C308@fujitsu-siemens.com> <3B2B31B2.E5E12C6F@tagish.com> <3B30DCC1.DCCBACD9@fujitsu-siemens.com> <3B30F4CE.BAA479D3@tagish.com> <3B31A153.FF437B94@fujitsu-siemens.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N One small point comes to light now you've released this: version.h is quite a common thing to have on your include path; certainly under MS operating systems there tends to be a version.h already on the include path which may cause confusion. Any reason not to call it jk_version.h? jean-frederic clere wrote: > > Andy Armstrong wrote: > > > > jean-frederic clere wrote: > > > > > > Hi, > > > > > > I have prepared a patch for configure.in to generate JK_EXPOSED_VERSION and > > > JK_VERSION. > > > The result is a file named common/version.h: > > > +++ > > > #define JK_EXPOSED_VERSION "mod_jk/1.2.0-dev" > > > #define JK_VERSION (((1) << 16) + ((2) << 8) + > > > (0)) > > > +++ > > > Any comments? - Otherwise I will commit it tomorrow - -- Andy Armstrong, Tagish