tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Initial comments on coyote
Date Thu, 14 Jun 2001 22:06:27 GMT
Hi Remy,

I looked at coyote, and it looks good ( the Request and Response are
simplified and have no deps on a higher layer ).

Few issues: 
- Note - the user should be able to store any object as a note, there is
no reason to require "recycle" on it ( if you want you could turn it into
"Recyclable" and check objects in the note[] for this interface ).

- AdapterListener/AdapterEventCode - that's an excelent idea ( to use the
"standard" Event/Listener model on connectors). But I think you should
follow the full pattern ( method signature doesn't match, Event must
extend j.u.Event ). I'm also not sure what's your intention for the even
direction ( is it intended to notify the layer above about the connector
events or to notify the connector about server events - I think both are
needed )

- Connector/Adapter interfaces - I'm not sure we need them from now, but
if you want to follow the event/listener model it would be nice to use it
here to.

I really like the idea of using only the simple Event/Listener pattern, I
think it would be very easy for developers to understand the code and
would allow maximum flexibility and decoupling. 

Would you mind moving the Request/Response in o.a.t.util.http ? They
depend on MimeHeader, etc - and it would make sense to call them 
HttpRequest or JTCRequest or something like that ( Request is used in 3.3,
4.0 - it would be confusing ). 


View raw message