tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marc Saegesser" <marc.saeges...@apropos.com>
Subject RE: Tomcat 3.2.2 beta 4
Date Wed, 02 May 2001 13:16:00 GMT
Glenn, Costin,

If Glenn is OK with it (since its his security manager stuff thats affected)
then I'm OK with it.  The class your talking about are the ones in the
org.apache.tomcat.util.compat package in the TC3.3 source, right?

I'm stuck in an all day meeting today (ouch) and then I've got to move
furniture tonight (ouch again) so I probably won't get to look at this
today.  If you guys get the new JDKcompat stuff in I'll review and test
tomorrow.

Thanks for all the help.

> -----Original Message-----
> From: glenn@zathras.earthdome.org [mailto:glenn@zathras.earthdome.org]On
> Behalf Of Glenn Nielsen
> Sent: Wednesday, May 02, 2001 6:38 AM
> To: tomcat-dev@jakarta.apache.org
> Subject: Re: Tomcat 3.2.2 beta 4
>
>
> Costin,
>
> The code you are referring to in 3.3 makes it easy to abstract out
> jdk 1.2 dependencies at build and runtime?  If so, I have no
> problems with you back porting that into 3.2.
>
> If these classes are generic enough, perhaps they could be put
> into the commons.
>
> Regards,
>
> Glenn
>
> cmanolache@yahoo.com wrote:
> >
> > On Tue, 1 May 2001, Marc Saegesser wrote:
> >
> > > Costin,
> > >
> > > The toLowerCase() patch look OK.
> > >
> > > If Glenn can fix the session id stuff easily then I think
> thats the best
> > > approach right now.
> >
> > Adding the jdkcompat package can't hurt - it'll be a minimal change in
> > SessionUtil plus the addition of 3 classes.
> >
> > I'll wait for Glenn - it's probably a 15 minutes fix if we use the stuff
> > from 33.
> >
> > Costin
> >
> > >
> > > > -----Original Message-----
> > > > From: cmanolache@yahoo.com [mailto:cmanolache@yahoo.com]
> > > > Sent: Tuesday, May 01, 2001 2:58 PM
> > > > To: tomcat-dev@jakarta.apache.org
> > > > Cc: glenn@more.net
> > > > Subject: RE: Tomcat 3.2.2 beta 4
> > > >
> > > >
> > > > Marc,
> > > >
> > > > I can quickly backport the jdkcompat package from 3.3 - it would be
> > > > cleaner than hacking generateSessionId.
> > > >
> > > > The package is "standalone", doesn't depend on any 3.3 feature - and
> > > > it's quite simple and effective.
> > > >
> > > > Also, if you could review the following patch that will fix "case
> > > > sensitive match for host names " ( the patch is ported from 3.3 ).
> > > >
> > > > Costin
> > > >
> > > > Index: src/share/org/apache/tomcat/util/PrefixMapper.java
> > > >
> =================================================================== RCS
> > > > file:
> > > > /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/util/PrefixMa
> > > > pper.java,v
> > > > retrieving revision 1.3.2.2 diff -r1.3.2.2 PrefixMapper.java
> > > > 125a126
> > > > >           host=host.toLowerCase();
> > > > 165a167
> > > > >           host=host.toLowerCasse();
> > > > 181a184
> > > > >           host=host.toLowerCase();
> > > > 201c204
> > > > < if( host!=null )
> > > > ---
> > > > >       if( host!=null ) {
> > > > 202a206,209
> > > > >           if( myMap==null ) {
> > > > >               myMap=(PrefixMapper)vhostMaps.get(
> host.toLowerCase() );
> > > > >           }
> > > > >       }
> > > >
> > > >
> > > >
> > >
>
> --
> ----------------------------------------------------------------------
> Glenn Nielsen             glenn@more.net | /* Spelin donut madder    |
> MOREnet System Programming               |  * if iz ina coment.      |
> Missouri Research and Education Network  |  */                       |
> ----------------------------------------------------------------------


Mime
View raw message