tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GOMEZ Henri <hgo...@slib.fr>
Subject RE: [TC3.3]Servlet-Engine Header in ajp13 and Http10 connectors
Date Fri, 04 May 2001 07:26:29 GMT
>On Tue, 1 May 2001, Ignacio J. Ortega wrote:
>
>> Hola a todos:
>> 
>> I'm wondering if the lack of "Servlet-Engine:" header in ajp13 and
>> http10 connectors is intentional or a missed feature ( for 
>>not call it a bug as for me it's not :)  ?? 

mod_jk has code for Servlet-Engine support but ajp13 didn't send
it now certainly for performance reasons. 

I take a look in Tomcat 4.0 and even in Resin but this Header
is not present. If "Servlet-Engine:" is required by specs we 
may add it but which RFC require this header ?

>> The same for the "Date" header in Http10 ?? 
>> 
>> "Date" header is mandatory , no?
>
>Yes, it's a bug for date, we must fix it. 
>
>For ajp13, ajp12, jni - the server should generate the date header, 
>and I would sugest to also generate the ServletEngine header in mod_jk,
>to avoid sending it over the wire on each request.

mod_jk could set the ServletEngine but it must know before which worker
run which servlet engine. In a farm of tomcat you could have at the
same time TC 3.2/3.2.1/3.3/4.0 ....

ajp14 will learn which version of servlet-engine is running at login time.

>The code for sending "date" is commented out in the Http1.0 connector, 
>it was very inefficient - and the idea was to use the same optimization
>that is used in Log ( FastDateFormat ) or copy the optimizations from 4.0
>( if any ). 

We could speed-up again a little FastDateFormat by also checking the full
date
since it may called by many threads in the same MS. I'll commit the patch
later :)
The Apache team grab this kind of optimization from SGI patches !!!

Mime
View raw message