tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vincent Schonau <vince-jaka...@netnautics.com>
Subject [PATCH] '8859_1' is not a valid charset alias
Date Fri, 18 May 2001 11:42:17 GMT
[this has also been entered as bug #1808]

Both Tomcat and Apache have the string '8859_1' hard-coded and as a public
static final String in several places.

Although Java accepts '8859_1' as an alias for the ISO-8859-1 character set,
this isn't a valid name anywhere else; the valid aliases are listed at

<URL:http://www.iana.org/assignments/character-sets>

Some user-agents (I first noticed this on an older version of Lynx) are
confused by this.

This patch will:

  - remove all references in code (not comments) to '8859_1'
  - In classes where this string was used, add a 
    public static final String DEFAULT_CHAR_ENCODING 
    if none was present (this is the most frequently used name
    when such a field is present)
  - In the src/org/apache/jasper tree:
    - add a 
      public static final String DEFAULT_CHAR_ENCODING
      to Constants.java
    - replace all occurrences of '8859_1' in code
      with Constants.DEFAULT_CHAR_ENCODING
      as this seems to me be the proper way to do this in Jasper.


Regards,


Vince.



Mime
View raw message