Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 79295 invoked by uid 500); 22 Apr 2001 22:42:51 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: tomcat-dev@jakarta.apache.org Delivered-To: mailing list tomcat-dev@jakarta.apache.org Delivered-To: moderator for tomcat-dev@jakarta.apache.org Received: (qmail 66630 invoked from network); 22 Apr 2001 17:10:02 -0000 Message-ID: <20010422171006.18926.qmail@web11908.mail.yahoo.com> Date: Sun, 22 Apr 2001 10:10:06 -0700 (PDT) From: Pogo Com Subject: [PATCH] mod_jk timestamp and process id logging To: tomcat-dev@jakarta.apache.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-1411676829-987959406=:18857" X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N --0-1411676829-987959406=:18857 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline >2) I suggest adding a timestamp to mod_jk-logging in jk_util.c. Logging >without a timestamp is not very useful. (change 1 line, add 2 lines) Yes, this is a must-have... the other thing that is really useful is the Apache child process id. That way if one process gets stuck, you can get the id from the Apache mod_status, and grep the mod_jk.log for that pid to see where it is. Attached is another version of the patch that adds both, relative to 3.3-m2. This was the only way that I could figure out that Tomcat didn't have enough threads in its thread pool for my Apache config! Bill __________________________________________________ Do You Yahoo!? Yahoo! Auctions - buy the things you want at great prices http://auctions.yahoo.com/ --0-1411676829-987959406=:18857 Content-Type: application/octet-stream; name="diff.out" Content-Transfer-Encoding: base64 Content-Description: diff.out Content-Disposition: attachment; filename="diff.out" LS0tIGprX3V0aWwuYy5vcmlnCVN1biBBcHIgMjIgMDk6NDI6NDEgMjAwMQ0K KysrIGprX3V0aWwuYwlTdW4gQXByIDIyIDA5OjQyOjM2IDIwMDENCkBAIC01 OSw3ICs1OSw3IEBADQogICogVmVyc2lvbjogICAgICRSZXZpc2lvbjogMS40 ICQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICoNDQogICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8NDQog DQ0KLQ0NCisjaW5jbHVkZSA8dGltZS5oPg0NCiAjaW5jbHVkZSAiamtfdXRp bC5oIg0NCiAjaW5jbHVkZSAiamtfYWpwMTJfd29ya2VyLmgiDQ0KIA0NCkBA IC0yMDQsNiArMjA0LDggQEANCiAgICAgICAgIGNoYXIgKmYgPSAoY2hhciAq KShmaWxlICsgc3RybGVuKGZpbGUpIC0gMSk7DQ0KICAgICAgICAgdmFfbGlz dCBhcmdzOw0NCiAgICAgICAgIGludCB1c2VkID0gMDsNDQorICAgICAgICBj aGFyIHRpbWVzdHJbMjRdOw0NCisgICAgICAgIHRpbWVfdCB0aW1ldDsNDQog DQ0KICAgICAgICAgd2hpbGUoZiAhPSBmaWxlICYmICdcXCcgIT0gKmYgJiYg Jy8nICE9ICpmKSB7DQ0KICAgICAgICAgICAgIGYtLTsNDQpAQCAtMjExLDE3 ICsyMTMsMjQgQEANCiAgICAgICAgIGlmKGYgIT0gZmlsZSkgew0NCiAgICAg ICAgICAgICBmKys7DQ0KICAgICAgICAgfQ0NCi0gICAgICAgICAgICAgICAg ICAgICAgIA0NCisNDQorICAgICAgICB0aW1ldCA9IHRpbWUoMCk7DQ0KKyAg ICAgICAgc3RyZnRpbWUodGltZXN0ciwgc2l6ZW9mKHRpbWVzdHIpLCAiJUg6 JU06JVMiLCBsb2NhbHRpbWUoJnRpbWV0KSk7DQ0KKw0NCisgICAgICAgIC8v IEhlYWRlciBmb3JtYXQgaXMgdGltZSwgcHJvY2VzcyBpZCAoMCBpZiB1bmtu b3duKSwgZmlsZSwgbGluZQ0NCisNDQogI2lmZGVmIFdJTjMyDQ0KLSAgICAg ICAgdXNlZCA9IF9zbnByaW50ZihidWYsIEhVR0VfQlVGRkVSX1NJWkUsICJb JXMgKCVkKV06ICIsIGYsIGxpbmUpOyAgICAgICAgDQ0KKyAgICAgICAgdXNl ZCA9IF9zbnByaW50ZihidWYsIEhVR0VfQlVGRkVSX1NJWkUsICJbJXMgMCAl cyAoJWQpXTogIiwNDQorICAgICAgICAgICAgICAgICAgICB0aW1lc3RyLCBm LCBsaW5lKTsgICAgICAgIA0NCiAjZWxpZiBkZWZpbmVkKE5FVFdBUkUpIC8v IHVudGlsIHdlIGdldCBhIHNucHJpbnRmIGZ1bmN0aW9uDQ0KICAgICAgICAg YnVmID0gKGNoYXIgKikgbWFsbG9jKEhVR0VfQlVGRkVSX1NJWkUpOw0NCiAg ICAgICAgIGlmIChOVUxMID09IGJ1ZikNDQogICAgICAgICAgICByZXR1cm4g LTE7DQ0KIA0NCi0gICAgICAgIHVzZWQgPSBzcHJpbnRmKGJ1ZiwgIlslcyAo JWQpXTogIiwgZiwgbGluZSk7DQ0KKyAgICAgICAgdXNlZCA9IHNwcmludGYo YnVmLCAiWyVzIDAgJXMgKCVkKV06ICIsIHRpbWVzdHIsIGYsIGxpbmUpOw0N CiAjZWxzZSANDQotICAgICAgICB1c2VkID0gc25wcmludGYoYnVmLCBIVUdF X0JVRkZFUl9TSVpFLCAiWyVzICglZCldOiAiLCBmLCBsaW5lKTsgICAgICAg IA0NCisgICAgICAgIHVzZWQgPSBzbnByaW50ZihidWYsIEhVR0VfQlVGRkVS X1NJWkUsICJbJXMgJWQgJXMgKCVkKV06ICIsDQ0KKyAgICAgICAgICAgIHRp bWVzdHIsIChpbnQpIGdldHBpZCgpLCBmLCBsaW5lKTsgICAgICAgIA0NCiAj ZW5kaWYNDQogICAgICAgICBpZih1c2VkIDwgMCkgew0NCiAgICAgICAgICAg ICByZXR1cm4gMDsgLyogW1ZdIG5vdCBzdXJlIHdoYXQgdG8gcmV0dXJuLi4u ICovDQ0K --0-1411676829-987959406=:18857--