Return-Path: 
 <tomcat-dev-return-19318-apmail-jakarta-tomcat-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org
Received: (qmail 11812 invoked by uid 500); 24 Mar 2001 21:10:31 -0000
Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:tomcat-dev-help@jakarta.apache.org>
list-unsubscribe: <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
list-post: <mailto:tomcat-dev@jakarta.apache.org>
Reply-To: tomcat-dev@jakarta.apache.org
Delivered-To: mailing list tomcat-dev@jakarta.apache.org
Received: (qmail 11803 invoked by uid 1059); 24 Mar 2001 21:10:31 -0000
Date: Sat, 24 Mar 2001 13:10:31 -0800 (PST)
From: "Craig R. McClanahan" <craigmcc@apache.org>
X-Sender: craigmcc@localhost
To: tomcat-dev@jakarta.apache.org
Subject: Re: cvs commit:
 jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/factory
 MailSessionFactory.java ResourceFactory.java
In-Reply-To: <008f01c0b4a5$e7f9df90$82deb018@intalio.com>
Message-ID: <Pine.BSF.4.21.0103241308470.8247-100000@localhost>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Spam-Rating: localhost 1.6.2 0/1000/N



On Sat, 24 Mar 2001, Remy Maucherat wrote:

> > Where?  This didn't work until I modified ResourceFactory to take care of
> > it, copying the way that the default resource factory for a DataSource is
> > set up.
> 
> You can set parameters for a resource (ejb-ref, resource-ref, and the
> others) with :
> 
> If the resource is jdbc/TestDB, the parameters are defined with :
> <ResourceParams name="jdbc/TestDB">
> 
> <parameter><name>factory</name><value>factory_class_name</value></parameter>
>  <parameter><name>user</name><value>sa</value></parameter>
>  <parameter><name>password</name><value></value></parameter>
>  <parameter><name>driverClassName</name>
>    <value>org.hsql.jdbcDriver</value></parameter>
>  <parameter><name>driverName</name>
>    <value>jdbc:HypersonicSQL:database</value></parameter>
> </ResourceParams>
> 

Oh, OK.  We should probably write up some simple docs on this.

Because javax.mail.Session is a standard J2EE resource type, I'm going to
go ahead and leave it defaulting to the factory I just created, so users
don't have to remember that.

I presume that a user-supplied factory would need to be visible to the
Catalina class loader, right?

> Note the factory parameter.
> 
> > Also, I noticed one other thing that I'm about to fix.  The entries for
> > resources, EJB references, and so on are getting created in the
> > "java:com" context.  According to the J2EE spec, they are supposed to be
> > in the "java:comp/env" context (along with environment entries).  It's a
> > real simple patch, to be submitted shortly after I double check that it
> > works correctly.
> 
> Yes, I made a mistake. I can fix it.
> 

See next CVS commit.

> Remy
> 
> 

Craig