Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 15530 invoked by uid 500); 17 Mar 2001 20:50:59 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: tomcat-dev@jakarta.apache.org Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 15521 invoked by uid 1059); 17 Mar 2001 20:50:58 -0000 Date: Sat, 17 Mar 2001 12:50:58 -0800 (PST) From: "Craig R. McClanahan" X-Sender: craigmcc@localhost To: tomcat-dev@jakarta.apache.org Subject: Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardWrapperValve.java In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: localhost 1.6.2 0/1000/N On Sat, 17 Mar 2001, Jon Stevens wrote: > on 3/17/01 12:07 PM, "craigmcc@apache.org" wrote: > > > + private String filter(String message) { > > Not sure if you have to do this for private methods, but you might want to > make that final in order to make sure that the JVM inlines the method. > I don't think you have to do that for final methods, but I'll look. > > Also, does that StandardWrapperValue filter for all responses or for just > Error page responses? If all responses, couldn't that be bad if I was > returning binary data? > This filtering is specifically called only on the request URI that is reported in a standard error page produced by Tomcat. No filtering is done on standard application output, or on error pages defined by a web app with the directive -- you are on your own to protect yourself. > -jon > > Craig