Return-Path: 
 <tomcat-dev-return-19317-apmail-jakarta-tomcat-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org
Received: (qmail 9814 invoked by uid 500); 24 Mar 2001 21:05:41 -0000
Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:tomcat-dev-help@jakarta.apache.org>
list-unsubscribe: <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
list-post: <mailto:tomcat-dev@jakarta.apache.org>
Reply-To: tomcat-dev@jakarta.apache.org
Delivered-To: mailing list tomcat-dev@jakarta.apache.org
Received: (qmail 9805 invoked from network); 24 Mar 2001 21:05:41 -0000
Message-ID: <008f01c0b4a5$e7f9df90$82deb018@intalio.com>
From: "Remy Maucherat" <remm@apache.org>
To: <tomcat-dev@jakarta.apache.org>
References: <Pine.BSF.4.21.0103241256330.6556-100000@localhost>
Subject: Re: cvs commit:
 jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/factory
 MailSessionFactory.java ResourceFactory.java
Date: Sat, 24 Mar 2001 13:03:41 -0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4133.2400
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400
X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N

> Where?  This didn't work until I modified ResourceFactory to take care of
> it, copying the way that the default resource factory for a DataSource is
> set up.

You can set parameters for a resource (ejb-ref, resource-ref, and the
others) with :

If the resource is jdbc/TestDB, the parameters are defined with :
<ResourceParams name="jdbc/TestDB">

<parameter><name>factory</name><value>factory_class_name</value></parameter>
 <parameter><name>user</name><value>sa</value></parameter>
 <parameter><name>password</name><value></value></parameter>
 <parameter><name>driverClassName</name>
   <value>org.hsql.jdbcDriver</value></parameter>
 <parameter><name>driverName</name>
   <value>jdbc:HypersonicSQL:database</value></parameter>
</ResourceParams>

Note the factory parameter.

> Also, I noticed one other thing that I'm about to fix.  The entries for
> resources, EJB references, and so on are getting created in the
> "java:com" context.  According to the J2EE spec, they are supposed to be
> in the "java:comp/env" context (along with environment entries).  It's a
> real simple patch, to be submitted shortly after I double check that it
> works correctly.

Yes, I made a mistake. I can fix it.

Remy