tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Downey <steve.dow...@netfolio.com>
Subject RE: [PATCH] Bug 841 - JSPC stack fault on NT
Date Mon, 05 Mar 2001 13:36:07 GMT
That's because in the JspEngineContext it gets to work purely URI name
space, not filesystem name space. It never gets file names, just URI's that
address jsp pages.

JSPC 'knows' that it's in filesystem space, and does things like parse the
file names for directories, looking for one that contains a WEB-INF. Now, NT
is actually agnostic about '/' and '\', but I'm not sure about 98 et al. It
seemed to me to be safer to convert it when it comes into the context rather
than outside it.

I should get to the <jsp:include> problems next. I'm using the heuristic
that JspC should be able to compile the example webapps. I'm not sure how to
structure that as a test, yet, though.


-----Original Message-----
From: Nick.Holloway@pyrites.org.uk [mailto:Nick.Holloway@pyrites.org.uk]
Sent: Saturday, March 03, 2001 4:56 AM
To: tomcat-dev@jakarta.apache.org
Subject: Re: [PATCH] Bug 841 - JSPC stack fault on NT


steve.downey@netfolio.com (Steve Downey) writes:
> Under NT (and presumably any OS where File.sep != '/') JspC has a stack
> underflow at baseDirStack.peek() in ParserController.java. This patch
> converts from '\' to '/' for those cases. It also sets the package name
for
> the class based on the URI, so that the java file is distinguished from
> others with the same name.

The problem with '\' as the filename seperator instead of '/' also
causes problems with "<jsp:include>", relative paths and JspC (see
Bugzilla #412).

I suggested there that it might be possible to just convert the '\'
into '/' before passing into CommandLineContext (in JspC).  This is
really what happens when running within Tomcat -- the path passed into
JspEngineContext has '/', not the local file seperator.

Unfortunately, I don't have a patch, as I'm not organised enough to get
a build environment running so I can test.

-- 
 `O O'  | Nick.Holloway@pyrites.org.uk
// ^ \\ | http://www.pyrites.org.uk/

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, email: tomcat-dev-help@jakarta.apache.org
<><><><><><><><><><><><><><><><><><><><><>This
electronic mail transmission
may contain confidential information and is intended only for the person(s)
named.  Any use, copying or disclosure by any other person is strictly
prohibited.  If you have received this transmission in error, please notify
the sender via e-mail. <><><><><><><><><><><><><><><><><><><><><>

Mime
View raw message