tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn Nielsen <gl...@voyager.apg.more.net>
Subject Re: first cut at tag pooling implementation
Date Mon, 12 Mar 2001 19:32:58 GMT
Great!

You will do before/after performance comparisons?

Have you tested your changes with Watchdog?

Which version of the Tomcat source are you working with?

Regards,

Glenn

Casey Lucas wrote:
> 
> The attached files and diffs are based on 3.3 (hopefully latest code).
> They add tag pooling for tomcat.  I hope that some of you will have
> time to take a look and provide feedback.  I mainly tested with our
> application that uses a lot of tags.
> 
> To disable pooling, don't include the TagPoolManagerInterceptor
> interceptor.  Jasper will still generate pooling code, but pooling
> won't be used at runtime.
> 
> Summary of changes:
> 
> 1. changed jasper to add tag pool support
> 
> files changed:
> org.apache.jasper.compiler.
>     JspParseEventListener.java
>     TagBeginGenerator.java
>     TagEndGenerator.java
> 
> files added:
> org.apache.jasper.compiler.
>     TagPoolManagerGenerator.java
>     TagPoolGenerator.java
> 
> 2. added tag pooling classes / interfaces
> files added:
> org.apache.jasper.runtime.
>     TagHandlerPool.java
>     TagHandlerPoolImpl.java
>     TagPoolManager.java
>     TagPoolManagerImpl.java
> 
> 3. added interceptor to enable tagging
> files added:
> org.apache.tomcat.modules.tagpool.
>     TagPoolManagerInterceptor.java
> 
> 4. changed modules.xml and server.xml
> added this text to end of modules.xml:
> 
> <module name="TagPoolManagerInterceptor" javaClass="org.apache.tomcat.modules.tagpool.TagPoolManagerInterceptor">
> <category name="tagpool"/>
> <doc>Not yet</doc>
> </module>
> 
> added this text to end of server.xml:
> <TagPoolManagerInterceptor/>
> 
> I'll post performance numbers as soon as I have something
> put togehter.  Please let me know if anyone has comments.
> 
> -Casey
> 
>   --------------------------------------------------------------------------------
>                                              Name: JspParseEventListener.java.diff
>    JspParseEventListener.java.diff           Type: unspecified type (application/octet-stream)
>                                          Encoding: quoted-printable
>                                   Download Status: Not downloaded with message
> 
>                                          Name: TagBeginGenerator.java.diff
>    TagBeginGenerator.java.diff           Type: unspecified type (application/octet-stream)
>                                      Encoding: quoted-printable
>                               Download Status: Not downloaded with message
> 
>                                        Name: TagEndGenerator.java.diff
>    TagEndGenerator.java.diff           Type: unspecified type (application/octet-stream)
>                                    Encoding: quoted-printable
>                             Download Status: Not downloaded with message
> 
>                                  Name: TagHandlerPool.java
>    TagHandlerPool.java           Type: JavaScript Program (application/x-javascript)
>                              Encoding: quoted-printable
>                       Download Status: Not downloaded with message
> 
>                                      Name: TagHandlerPoolImpl.java
>    TagHandlerPoolImpl.java           Type: JavaScript Program (application/x-javascript)
>                                  Encoding: quoted-printable
>                           Download Status: Not downloaded with message
> 
>                                    Name: TagPoolGenerator.java
>    TagPoolGenerator.java           Type: JavaScript Program (application/x-javascript)
>                                Encoding: quoted-printable
>                         Download Status: Not downloaded with message
> 
>                                  Name: TagPoolManager.java
>    TagPoolManager.java           Type: JavaScript Program (application/x-javascript)
>                              Encoding: quoted-printable
>                       Download Status: Not downloaded with message
> 
>                                           Name: TagPoolManagerGenerator.java
>    TagPoolManagerGenerator.java           Type: JavaScript Program (application/x-javascript)
>                                       Encoding: quoted-printable
>                                Download Status: Not downloaded with message
> 
>                                      Name: TagPoolManagerImpl.java
>    TagPoolManagerImpl.java           Type: JavaScript Program (application/x-javascript)
>                                  Encoding: quoted-printable
>                           Download Status: Not downloaded with message
> 
>                                             Name: TagPoolManagerInterceptor.java
>    TagPoolManagerInterceptor.java           Type: JavaScript Program (application/x-javascript)
>                                         Encoding: quoted-printable
>                                  Download Status: Not downloaded with message
> 
>    Part 1.12           Type: Plain Text (text/plain)
>             Download Status: Not downloaded with message

-- 
----------------------------------------------------------------------
Glenn Nielsen             glenn@more.net | /* Spelin donut madder    |
MOREnet System Programming               |  * if iz ina coment.      |
Missouri Research and Education Network  |  */                       |
----------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, email: tomcat-dev-help@jakarta.apache.org


Mime
View raw message