tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Delisle <pierre.deli...@sun.com>
Subject Re: cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler BeanGenerator.java JspParseEventListener.java ParserXJspSaxHandler.java
Date Sun, 10 Dec 2000 06:39:08 GMT


Hans Bergsten wrote:
> 
> pierred@locus.apache.org wrote:
> >
> > pierred     00/12/09 21:56:44
> >
> >   Modified:    jasper/src/share/org/apache/jasper Constants.java
> >                jasper/src/share/org/apache/jasper/compiler
> >                         BeanGenerator.java JspParseEventListener.java
> >                         ParserXJspSaxHandler.java
> >   Log:
> >   Take 2 on the default list of imports for JSP generated classes.
> >   Removed java.io.IOException, java.beans.Beans, and org.apache.jasper.Exception.
> >   All that's left is org.apache.jasper.runtime.*.
> >   That will be in take 3 (eventually :-))
> >   [Thanks to Craig for "waking me up" on this...]
> 
> Sorry, but I don't see what difference this change make. You're not
> removing dependencies, just removing imports and replacing them with
> FQCNs in the code. Why?

Agree. Does not make a difference besides having a shorter import list.
[Craig had made a comment about "java.Beans.*", but in fact I was only
importing java.beans.Beans.]

Might be better to leave those in the import list to make the 
dependency clear. What do you think? 

    -- Pierre


> 
> Hans
> --
> Hans Bergsten           hans@gefionsoftware.com
> Gefion Software         http://www.gefionsoftware.com
> Author of JavaServer Pages (O'Reilly), http://TheJSPBook.com

Mime
View raw message