tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Takashi Okamoto" <tokam...@rd.nttdata.co.jp>
Subject Re: [BUG & PATCH] for Kaffe VM
Date Thu, 28 Dec 2000 10:53:46 GMT
Hi, Tomcat developers.

> > I found problem that tomcat 3.2-b8 doesn't work on Kaffe VM.
> > (probably 3.2 final is same)
> > Error occurs at read() method in java.io.BufferedInputStream.

I had a contact to Edouard  who is one of Kaffe VM developer.
He said Tomcat should be fixed.

I forward him mail.
Please fix this problem.

If tomcat don't work on Kaffe VM,<b>Tomcat can't be included Debian main
package</b>
because JDK and JRE isn't free software.


Regards.
--------- mail form Edouard ------------------
Takashi Okamoto wrote:

> > Could you test the following changes:
> >
> > In methods read() and skip() of java.io.BufferedInputStream, change test
> >     pos == buf.length
> > by
> >     pos == buf.length || pos >= count
> >
> > and say me if it work.
>
> It's good. Tomcat worked.

Well, I think others methods may not work too (available, mark, reset).

As BufferedInputStream constructor initialize pos, count and markpos, I
think it's a org.apache.tomcat.util.RecycleBufferedInputStream bug.

If setInputStream() and reclycle() do the RightThinkTM, I hope that
Tomcat will work with unmodified Kaffe and GNU Classpath
BufferedInputStream class.

Try the following changes and use unmodified BufferedInputStream.  If
Tomcat then work, could you fill a bug report to Tomcat team ?

    public void setInputStream( InputStream is ) {
this.in = is;
this.pos = this.count = 0;
this.markpos = -1;
    }

    public void recycle() {
this.in = null;
this.pos = this.count = 0;
this.markpos = -1;
    }

Hope this help.
--
Edouard G. Parmelan
http://egp.free.fr

---------
Takashi Okamoto



Mime
View raw message