Return-Path: Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 10382 invoked from network); 5 Nov 2000 03:44:39 -0000 Received: from e24.nc.us.ibm.com (32.97.136.230) by locus.apache.org with SMTP; 5 Nov 2000 03:44:39 -0000 Received: from southrelay02.raleigh.ibm.com (southrelay02.raleigh.ibm.com [9.37.3.209]) by e24.nc.us.ibm.com (8.9.3/8.9.3) with ESMTP id WAA19072 for ; Sat, 4 Nov 2000 22:46:19 -0600 Received: from d04nms20.raleigh.ibm.com (d04nms19nms20.raleigh.ibm.com [9.67.228.10]) by southrelay02.raleigh.ibm.com (8.8.8m3/NCO v4.95) with ESMTP id WAA29276 for ; Sat, 4 Nov 2000 22:44:34 -0500 Importance: Normal Subject: Re: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core Handler.java To: tomcat-dev@jakarta.apache.org X-Mailer: Lotus Notes Release 5.0.4 June 8, 2000 Message-ID: From: "Sam Ruby/Raleigh/IBM" Date: Sat, 4 Nov 2000 22:44:42 -0500 X-MIMETrack: Serialize by Router on D04NMS20/04/M/IBM(Release 5.0.3 (Intl)|21 March 2000) at 11/04/2000 10:44:37 PM MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > public void service(Request req, Response res) > throws IOException, ServletException > { > + synchronized(this) { > if( ! initialized ) { > try { > init(); > @@ -271,6 +272,7 @@ > return; > } > } > + } This looks significant from a performance perspective. Wouldn't it be better if an _additional_ if (!initialized) were added prior to the synchronized? - Sam Ruby