Return-Path: Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 77456 invoked from network); 24 Nov 2000 07:48:55 -0000 Received: from purveyor7.dresdnerbank.de (193.194.7.53) by locus.apache.org with SMTP; 24 Nov 2000 07:48:55 -0000 Received: from ffz00egp.WWZ0ME.Mail.Dresdner.net (unverified) by purveyor7.Dresdnerbank.de (Content Technologies SMTPRS 2.0.15) with ESMTP id for ; Fri, 24 Nov 2000 08:48:48 +0100 Received: by ffz00egp.wwz0me.mail.dresdner.net with Internet Mail Service (5.5.2448.0) id ; Fri, 24 Nov 2000 08:48:48 +0100 Message-Id: <838E11BB31D0D3119DBF0008C7A47FE702106A39@ffz00za6.wwz1me.mail.dresdner.net> From: "Schmitt, Christian" To: tomcat-dev@jakarta.apache.org Subject: Patch for JikesJavaCompiler.java Date: Fri, 24 Nov 2000 08:48:47 +0100 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2448.0) Content-Type: multipart/mixed; boundary="----_=_NextPart_000_01C055EA.FA92075A" X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. ------_=_NextPart_000_01C055EA.FA92075A Content-Type: text/plain; charset="iso-8859-1" Hi all, we've been working with TC 4.0 (M2) for some time now. We treid to get Jikes to compile our JSP pages but it would not work (TC 4.0, JDK1.3, Debian Linux 2.2). So I looked at the JikesJavaCompiler.java file and found what I believe is a bug where the double quotes surround classpath et. al. Attached is a diff that uses the double quotes only in case of TC running under Windows. Hope this helps, Christian ------_=_NextPart_000_01C055EA.FA92075A Content-Type: application/octet-stream; name="JikesJavaCompiler.java.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="JikesJavaCompiler.java.diff" Nov 23 16:23:23 cvs[25708]: dante/client v1.1.5 running=0A= Index: JikesJavaCompiler.java=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: = /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/co= mpiler/JikesJavaCompiler.java,v=0A= retrieving revision 1.2=0A= diff -u -r1.2 JikesJavaCompiler.java=0A= --- JikesJavaCompiler.java 2000/09/01 15:58:44 1.2=0A= +++ JikesJavaCompiler.java 2000/11/23 15:23:24=0A= @@ -1,5 +1,5 @@=0A= /*=0A= - * $Header: = /home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/co= mpiler/JikesJavaCompiler.java,v 1.2 2000/09/01 15:58:44 pierred Exp = $=0A= + * $Header: = /home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler= /JikesJavaCompiler.java,v 1.2 2000/09/01 15:58:44 pierred Exp $=0A= * $Revision: 1.2 $=0A= * $Date: 2000/09/01 15:58:44 $=0A= *=0A= @@ -134,12 +134,14 @@=0A= public boolean compile(String source) {=0A= Process p;=0A= int exitValue =3D -1;=0A= + String quote =3D "";=0A= =0A= // Used to dynamically load classpath if using Microsoft =0A= // virtual machine=0A= if (MicrosoftClasspath=3D=3Dnull) {=0A= MicrosoftClasspath =3D new StringBuffer(200);=0A= if = (System.getProperty("java.vendor").startsWith("Microsoft")) {=0A= + quote =3D "\"";=0A= //Get Microsoft classpath=0A= String javaHome =3D System.getProperty("java.home") + = =0A= "\\Packages";=0A= @@ -152,12 +154,12 @@=0A= }=0A= =0A= String[] compilerCmd =3D new String[] {=0A= - "\"" + compilerPath + "\"",=0A= + quote + compilerPath + quote,=0A= //XXX - add encoding once Jikes supports it=0A= - "-classpath", "\"" + classpath + MicrosoftClasspath + = "\"",=0A= - "-d", "\"" + outdir + "\"",=0A= + "-classpath", quote + classpath + MicrosoftClasspath + = quote,=0A= + "-d", quote + outdir + quote,=0A= "-nowarn",=0A= - "\"" + source + "\""=0A= + quote + source + quote=0A= };=0A= =0A= ByteArrayOutputStream tmpErr =3D new = ByteArrayOutputStream(OUTPUT_BUFFER_SIZE);=0A= ------_=_NextPart_000_01C055EA.FA92075A--