tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remy Maucherat" <>
Subject Re: [PROPOSAL] Tomcat 4.0 Milestone 5
Date Thu, 23 Nov 2000 04:20:46 GMT
> > I would like that by default it doesn't do any kind of pattern matching
> > all (unless one is explicitely specified), and just output the standard
> You're talking about the AccessLogValve itself, right?


> You want an
> AccessLogValve that doesn't do any fancy pattern stuff, but built only
> to do the common log format?

Let's say something like :
if (pattern.equals(COMMON_ALIAS)) {
   log something hard coded which looks like the default pattern
} else {
   do the old stuff (which could perhaps be optimized more)

> Yes, that would sure help it to perform,
> wouldn't it?  And, we could have another Valve that does the fancy log
> patterns of people want that feature.

We should be able to do both in the same Valve, IMO. Of course, two valves
would get the job done too.


View raw message