tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Serge Knystautas" <ser...@lokitech.com>
Subject Patch for bug report #362 (and a patch for a logging error)
Date Thu, 09 Nov 2000 04:14:07 GMT
Ok, I submitted the bug report this afternoon (#362) about how jasper was
mishandling a custom tag of mine.  You can read the report if you want, but
basically here's what happens... say your custom tag has an attribute to be
rtexprvalue and because of the flexibility of the tag, you make the setter
method take a java.lang.Object value.  When you then set a non-dynamic value
in your JSP (rather than passing some object, just write attr="value"),
jasper throws this funny message that says it "can't cast String to
java.lang.Object."

Not a high priority thing, but I think pretty useful (especially since I'd
like to use these custom tags I wrote!!)  I read over the JSP spec several
times and don't see how this would be a violation of the spec.  Included
below is the 2 line patch.

In testing this patch, I also found a bug in the Logger that was ignoring
the verbosity level setting and just dumping *everything* to the log.  So
there's a second one line patch as well.

These are diff'd off of the CVS tree as of this evening (8 Nov 00)...


Index: jasper/compiler/TagBeginGenerator.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagBegin
Generator.java,v
retrieving revision 1.16
diff -r1.16 TagBeginGenerator.java
269a270,271
>   } else if (c == Object.class) {
>    return writer.quoteString(s);


Index: tomcat/util/log/Logger.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/util/log/Logger.j
ava,v
retrieving revision 1.1
diff -r1.1 Logger.java
344c344
<  log(message, null, level);
---
>  log(message, null, verbosityLevel);


Serge Knystautas
Loki Technologies
http://www.lokitech.com/


Mime
View raw message