tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <Craig.McClana...@eng.sun.com>
Subject Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector HttpResponseBase.java
Date Sat, 07 Oct 2000 18:41:56 GMT
remm@locus.apache.org wrote:

> remm        00/10/07 11:37:37
>
>   Modified:    catalina/src/share/org/apache/catalina/connector
>                         HttpResponseBase.java
>   Log:
>   - Force committed to true after sending the headers. Otherwise, they could
>     be sent twice.
>

Shouldn't this flag setting actually be at the end of sendHeaders() (rather than finishResponse())
so that it works even when sendHeaders() is called from
elsewhere?

Craig


>
>   Revision  Changes    Path
>   1.12      +5 -4      jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java
>
>   Index: HttpResponseBase.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -r1.11 -r1.12
>   --- HttpResponseBase.java     2000/10/06 05:10:20     1.11
>   +++ HttpResponseBase.java     2000/10/07 18:37:37     1.12
>   @@ -1,7 +1,7 @@
>    /*
>   - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
1.11 2000/10/06 05:10:20 craigmcc Exp $
>   - * $Revision: 1.11 $
>   - * $Date: 2000/10/06 05:10:20 $
>   + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
1.12 2000/10/07 18:37:37 remm Exp $
>   + * $Revision: 1.12 $
>   + * $Date: 2000/10/07 18:37:37 $
>     *
>     * ====================================================================
>     *
>   @@ -96,7 +96,7 @@
>     * methods need to be implemented.
>     *
>     * @author Craig R. McClanahan
>   - * @version $Revision: 1.11 $ $Date: 2000/10/06 05:10:20 $
>   + * @version $Revision: 1.12 $ $Date: 2000/10/07 18:37:37 $
>     */
>
>    public class HttpResponseBase
>   @@ -169,6 +169,7 @@
>        public void finishResponse() throws IOException {
>
>            sendHeaders();
>   +        committed = true;
>            super.finishResponse();
>
>        }
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org

--
====================
See you at ApacheCon Europe <http://www.apachecon.com>!
Session VS01 (23-Oct 13h00-17h00):  Sun Technical Briefing
Session T06  (24-Oct 14h00-15h00):  Migrating Apache JServ
                                    Applications to Tomcat



Mime
View raw message