tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lar...@locus.apache.org
Subject cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java
Date Fri, 06 Oct 2000 11:10:15 GMT
larryi      00/10/06 04:10:15

  Modified:    src/share/org/apache/jasper/compiler TagLibraryInfoImpl.java
  Log:
  Didn't interpret Pierre Delisle's patch correctly.  I was up too late the night
  before.  Now it's correct.
  
  For reference, here is Pierre's commit message which explains the original problem:
  
  It is the tag <uri> in the TLD that sets the value of the
  'urn' field, not <urn>.
  
  And for more details:
  
  Referring to bug 214, Hans Bergsten wrote:
  > Looking at the code, it seems like it's a bug that an element named
  > "urn" is processed instead of the "uri" element. But I assume this
  > only means that the "uri" element is (incorrectly) ignored but that
  > the TLD is still parseable. Since the "uri" element is intended to
  > be used by development tools rather than the container, this should
  > not be a fatal problem.
  
  Correct.
  
  I must admit the spec is quite confusing on that matter.
  
  The confusion comes from the fact that the <uri> subelement of <taglib>
  in the TLD is mapped to the 'urn' field of TagLibraryInfo
  (which is accessible via the method getReliableURN()).
  
  This 'reliable urn' is not used anywhere else in the source base.
  As Hans mentioned, it is "intended to be used by development tools
  rather than the container".
  
  The code simply needs to be fixed by accepting the tag <uri> in the TLD
  instead of <urn>.
  
  [Wish the tag was named something like <reliableurn> in the
  TLD instead of <uri> to remove the confusion.
  
  And, for completeness, the 'uri' field of TagLibraryInfo is set
  via the 'uri' attribute of the taglib directive. It is accessible
  via the getURI() method of TagLibraryInfo]
  
  Revision  Changes    Path
  1.29      +5 -4      jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java
  
  Index: TagLibraryInfoImpl.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- TagLibraryInfoImpl.java	2000/10/05 22:46:56	1.28
  +++ TagLibraryInfoImpl.java	2000/10/06 11:10:15	1.29
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
1.28 2000/10/05 22:46:56 larryi Exp $
  - * $Revision: 1.28 $
  - * $Date: 2000/10/05 22:46:56 $
  + * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagLibraryInfoImpl.java,v
1.29 2000/10/06 11:10:15 larryi Exp $
  + * $Revision: 1.29 $
  + * $Date: 2000/10/06 11:10:15 $
    *
    * The Apache Software License, Version 1.1
    *
  @@ -122,8 +122,9 @@
           print("tlibversion", tlibversion, out);
           print("jspversion", jspversion, out);
           print("shortname", shortname, out);
  -        print("uri", uri, out);
  +        print("urn", urn, out);
           print("info", info, out);
  +        print("uri", uri, out);
   
           for(int i = 0; i < tags.length; i++)
               out.println(tags[i].toString());
  
  
  

Mime
View raw message