tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pierre Delisle <pierre.deli...@sun.com>
Subject Re: Minor things in Tomcat-4.0 build.xml
Date Wed, 20 Sep 2000 19:55:38 GMT
Bob,

Thanks for your feedback on the build procedure of tomcat-4.0.
Comments included below.
Please get the latest sources for the fixes. 

> I have been checking out and building tomcat-4.0 lately, and I
> just thought I would point out a few minor typos in the
> build.xml files.
> 
> 1.  In <toplevel>/build.xml and catalina/build.xml, regexp.jar's location is:
> 
>   <property name="regexp.jar"      value="${regexp.home}/bin/jakarta-regexp-1.1.jar"/>
>
> Apparently is has moved in the nightly .zip and it now appears to be:
> 
>   <property name="regexp.jar"      value="${regexp.home}/jakarta-regexp-1.1.jar"/>

Given that the jar file may reside in a different location depending whether 
one uses the source or binary distribution, REGEXP_HOME must now be specified
and the script expects to find the jar file at the top level.
(when using the source distribution, then REGEXP_HOME must point to the
bin directory of the install)

> 
> 2.  Also, the name "jaxp.jar" no longer exists in build.xml, so I changed the javac
> command in catalina/build.xml from
> 
> <javac   srcdir="src/share" destdir="${catalina.build}/classes"
> 
> classpath="${jaxp.jar}:${regexp.jar}:${servlet.jar}:${jcert.jar}:${jnet.jar}:${jsse.jar}"
> 
>          deprecation="off" debug="on" optimize="off" target="1.2"
>          excludes="**/CVS/**"/>
> 
> to
> 
> <javac   srcdir="src/share" destdir="${catalina.build}/classes"
> 
> classpath="${xerces.jar}:${regexp.jar}:${servlet.jar}:${jcert.jar}:${jnet.jar}:${jsse.jar}"
> 
>          deprecation="off" debug="on" optimize="off" target="1.2"
>          excludes="**/CVS/**"/>

Fixed. 

> 3.  However, since Ant needs xerces.jar to run in the first place, then this might
> be redundant, since xerces.jar will need to be in the CLASSPATH.  If so, then possibly
> the build.sh files should have the CP variable as:
> 
> CP=$ANT_HOME/lib/ant.jar:$JAVA_HOME/lib/tools.jar:$XERCES_HOME/xerces.jar

Fixed.

	-- Pierre

Mime
View raw message