tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoff Soutter" <ge...@whitewolf.com.au>
Subject URL decoding again (was Re: Tomcat 3.2 beta3?)
Date Mon, 04 Sep 2000 00:34:15 GMT
Nacho,

yeah, whoops looks like 3.3 is broken too huh. Hmm.

where to do the fix is a bit tricky, actually because we need to consider
wether we match against decoded values or not. E.g. if URI is /context%20one
and there is a "context one" is it a match or not. Unfortunately this isn't
covered in the specification (yet).

I'd really like to see if get fixed for 3.2, I mean how can we release
Tomcat given it's supposed to be the reference implementation if we know
it's not spec compliant? And I guess we'd then need to port the "proper" fix
across to 3.3?

Even though I've been trying to avoid it for ages :-), I'd be prepared to
have a go at doing a decent patch if no-one more familiar with this code is
prepared to have a go...

cheers

Geoff

----- Original Message -----
From: "Nacho" <nacho@siapi.es>
To: <tomcat-dev@jakarta.apache.org>
Sent: Saturday, September 02, 2000 1:00 AM
Subject: RE: Tomcat 3.2 beta3?


> The errata especification say this:
> 8<----------------------------------------------------------------------
> -------
> 1) Clarify in javadoc for HttpRequest the following encoding rules for
> these API calls.
>
> getServletPath() - decoded
> getPathInfo() - decoded
> getRequestURI() - remain encoded
> getContextPath() - remain encoded
> getPathTranslated() - remain decoded
> 8<----------------------------------------------------------------------
>
> I'm reviewing what you say, i'm not sure this the patch really needed as
> in decodes the uri too, and we need that the RequestURI remain encoded,
> i think is better to do a patch in fixRequestPaths inside SimpleMapper1,
> and perhaps fix things inside staticInterceptor and related...
>
> Saludos ,
> Ignacio J. Ortega
>
>
>
> > -----Mensaje original-----
> > De: Geoff Soutter [mailto:geoff@whitewolf.com.au]
> > Enviado el: viernes 1 de septiembre de 2000 9:05
> > Para: tomcat-dev@jakarta.apache.org
> > Asunto: Re: Tomcat 3.2 beta3?
> >
> >
> > Tomcat 3.2 still doesn't decode simple % encoding in URLs. (I
> > originally
> > reported this just before 3.1 went out!)
> >
> > This means it's in violation of the 2.2 specification errata
> > which states
> > that getServletPath() and getPathInfo() return % decoded values.
> >
> > It's fixed in 3.3 (in the last few lines of
> > service.http.HttpRequestAdaptor.processRequestLine()) and
> > seems to work ok.
> >
> > Can I request that one of the commiters back-port this fix
> > before we decare
> > 3.2 final please?
> >
> > Cheers
> >
> > Geoff
> >
> > ----- Original Message -----
> > From: <rubys@us.ibm.com>
> > To: <tomcat-dev@jakarta.apache.org>
> > Sent: Friday, September 01, 2000 4:55 AM
> > Subject: RE: Tomcat 3.2 beta3?
> >
> >
> > >
> > >
> > > Petr Jiricka wrote:
> > > >
> > > >  I just saw that there is a link on the Jakarta site !
> > > > http://jakarta.apache.org/builds/tomcat/release/v3.2-beta-3/
> > >
> > > Yes, it is out there.  Hopefully, this will be the last
> > beta for this
> > > release.  If no showstoppers are found, I'll call for a
> > vote sometime
> > > tomorrow, with the hope for publishing the final release
> > sometime next
> > > week.
> > >
> > > - Sam Ruby
> > >
> > >
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
>


Mime
View raw message