tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jay Freeman \(saurik\)" <>
Subject [PATCH] 8k Ajp13 Response Limit (was: RE: Bugs/patches - need help)
Date Thu, 06 Jul 2000 23:48:24 GMT
Already mentioned this problem, and already gave this patch, but I didn't
say "[PATCH]" in my subject last time (didn't realize people were doing that
at the time), so maybe this got overlooked (and since no one commented that
I was crazy and this wasn't really a problem, thought I would mention it
again, since it seems like a big problem for someone who tries to use Ajp13
and can't figure out why it fails while Ajp12 works fine).  Regardless, it
is a simple fix (one character change).  To verify it try using Ajp13 to
retrieve a really large JSP file, or even:

cat /dev/zero | head -c 10000 > myfile.jsp

Comes back with "Buffer overflow" messages due to a miscalculation of the
available space in the TCP packet.

diff -u -r1.4
2000/05/30 06:16:48     1.4
2000/07/03 19:27:03
@@ -77,7 +77,7 @@
        public static final int  MAX_SEND_SIZE =
TcpConnector.MAX_PACKET_SIZE -
                                                 TcpConnector.H_SIZE -
-                                                2;
+                                                4;

     public static final byte JK_AJP13_SEND_BODY_CHUNK   = 3;
     public static final byte JK_AJP13_SEND_HEADERS      = 4;

Jay Freeman (saurik)

-----Original Message-----
From: []On Behalf Of Costin
Sent: Thursday, July 06, 2000 4:52 PM
To: Tomcat
Subject: Bugs/patches - need help


I will be very slow this and next week, I have a lot of
(non-tomcat) work to do.

If anyone has a bit more time, please take a look and
review and commit the patches we have so far...

I'll do some fixes and commit whatever remains this
and next weekend.

I think at least the following patches must go into 3.2:

-  WEB-INF ( major )
- log() fails in jsp
- admin - disabled by default
- dtd misspelled
- - patch to FileUtil
- - SSL patch
- remove non-jaxp deps
- space in URLs

- few stack traces should be removed
- better messages if .keystore not found


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message