tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <Craig.McClana...@eng.sun.com>
Subject Re: cvs commit: jakarta-tomcat/src/admin/WEB-INF/classes ContextAdmin.java
Date Fri, 28 Jul 2000 16:40:44 GMT
Pilho Kim wrote:

> Hi, Craig
>
> I think that there doesn't need RequestUtil.URLDecode in the following:
>
>         if (context.getWorkDir() != null)
>            v.addElement("WORK DIR: " + RequestUtil.URLDecode(context.getWorkDir(
> ).getName()));
>
> because context.getWorkDir() is already a File object.
>
> How about my openion ?
>

That is undoubtedly true (although I suspect that at one point the getWorkDir() method might
have
returned a string) -- I was only after making the minimum fix needed to get my compiles working
again.  I haven't actually ever looked a the code in the admin app before.

Any committer who wants to is welcome to clean this stuff up ... unfortunately, I've got schedule
commitments in the near term.

>
> Thanx
>
> Kim
>

Craig McClanahan


>
> >
> > craigmcc    00/07/27 19:32:05
> >
> >   Modified:    src/admin/WEB-INF/classes ContextAdmin.java
> >   Log:
> >   Correct a compile error that breaks "./build.sh dist".  This should probably
> >   be rolled into TOMCAT_32 as well.
> >
> >   Revision  Changes    Path
> >   1.5       +1 -1      jakarta-tomcat/src/admin/WEB-INF/classes/ContextAdmin.java
> >
> >   Index: ContextAdmin.java
> >   ===================================================================
> >   RCS file: /home/cvs/jakarta-tomcat/src/admin/WEB-INF/classes/ContextAdmin.java,v
> >   retrieving revision 1.4
> >   retrieving revision 1.5
> >   diff -u -r1.4 -r1.5
> >   --- ContextAdmin.java       2000/06/22 23:48:55     1.4
> >   +++ ContextAdmin.java       2000/07/28 02:32:04     1.5
> >   @@ -61,7 +61,7 @@
> >       context = cm.getContext(contextName);
> >
> >       v.addElement("DOC BASE: " + context.getDocBase());
> >   -   v.addElement("FULL DOC BASE: " + context.getDocumentBase().toString());
> >   +   v.addElement("FULL DOC BASE: " + context.getAbsolutePath());
> >       v.addElement("PATH: " + context.getPath());
> >       if (context.getWorkDir() != null)
> >          v.addElement("WORK DIR: " + RequestUtil.URLDecode(context.getWorkDir().getName()));
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message