tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cos...@eng.sun.com>
Subject Re: [PATCH] 8k Ajp13 Response Limit (was: RE: Bugs/patches - need help)
Date Fri, 07 Jul 2000 00:22:32 GMT
Great fix ( even if it's one char change ) !!

I am very happy Ajp13 is used, maybe next release we can default to 13 !

Costin

> Already mentioned this problem, and already gave this patch, but I didn't
> say "[PATCH]" in my subject last time (didn't realize people were doing that
> at the time), so maybe this got overlooked (and since no one commented that
> I was crazy and this wasn't really a problem, thought I would mention it
> again, since it seems like a big problem for someone who tries to use Ajp13
> and can't figure out why it fails while Ajp12 works fine).  Regardless, it
> is a simple fix (one character change).  To verify it try using Ajp13 to
> retrieve a really large JSP file, or even:
>
> cat /dev/zero | head -c 10000 > myfile.jsp
>
> Comes back with "Buffer overflow" messages due to a miscalculation of the
> available space in the TCP packet.
>
> diff -u -r1.4 Ajp13ConnectorResponse.java
> ---
> src/share/org/apache/tomcat/service/connector/Ajp13ConnectorResponse.java
> 2000/05/30 06:16:48     1.4
> +++
> src/share/org/apache/tomcat/service/connector/Ajp13ConnectorResponse.java
> 2000/07/03 19:27:03
> @@ -77,7 +77,7 @@
>  {
>         public static final int  MAX_SEND_SIZE =
> TcpConnector.MAX_PACKET_SIZE -
>                                                  TcpConnector.H_SIZE -
> -                                                2;
> +                                                4;
>
>      public static final byte JK_AJP13_SEND_BODY_CHUNK   = 3;
>      public static final byte JK_AJP13_SEND_HEADERS      = 4;
>
> Sincerely,
> Jay Freeman (saurik)
> saurik@saurik.com
>
> -----Original Message-----
> From: costin@costin.dnt.ro [mailto:costin@costin.dnt.ro]On Behalf Of Costin
> Manolache
> Sent: Thursday, July 06, 2000 4:52 PM
> To: Tomcat
> Subject: Bugs/patches - need help
>
> Hi,
>
> I will be very slow this and next week, I have a lot of
> (non-tomcat) work to do.
>
> If anyone has a bit more time, please take a look and
> review and commit the patches we have so far...
>
> I'll do some fixes and commit whatever remains this
> and next weekend.
>
> I think at least the following patches must go into 3.2:
>
> - Larry.Isaacs@sas.com:  WEB-INF ( major )
> - log() fails in jsp
> - admin - disabled by default
> - dtd misspelled
> - jdr5@pacbell.net - patch to FileUtil
> - onstine@intalio.com - SSL patch
> - remove non-jaxp deps
> - geoff@whitewolf.com.au: space in URLs
>
> plus:
> - few stack traces should be removed
> - better messages if .keystore not found
>
> Costin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message