tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From craig...@locus.apache.org
Subject cvs commit: jakarta-tomcat/proposals/catalina/src/share/org/apache/tomcat/realm MemoryRealm.java
Date Thu, 27 Jul 2000 01:27:27 GMT
craigmcc    00/07/26 18:27:24

  Modified:    proposals/catalina/src/share/org/apache/tomcat/realm
                        MemoryRealm.java
  Log:
  Memo to self ... when optimizing a loop that parses a comma-delimited string,
  do *not* (under penalty of an endless loop) remove the statement that advances
  the parser past the comma :-(.
  
  Thanks for the thread dump Geoff!
  
  Revision  Changes    Path
  1.8       +5 -4      jakarta-tomcat/proposals/catalina/src/share/org/apache/tomcat/realm/MemoryRealm.java
  
  Index: MemoryRealm.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/proposals/catalina/src/share/org/apache/tomcat/realm/MemoryRealm.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- MemoryRealm.java	2000/07/26 23:13:06	1.7
  +++ MemoryRealm.java	2000/07/27 01:27:20	1.8
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-tomcat/proposals/catalina/src/share/org/apache/tomcat/realm/MemoryRealm.java,v
1.7 2000/07/26 23:13:06 craigmcc Exp $
  - * $Revision: 1.7 $
  - * $Date: 2000/07/26 23:13:06 $
  + * $Header: /home/cvs/jakarta-tomcat/proposals/catalina/src/share/org/apache/tomcat/realm/MemoryRealm.java,v
1.8 2000/07/27 01:27:20 craigmcc Exp $
  + * $Revision: 1.8 $
  + * $Date: 2000/07/27 01:27:20 $
    *
    * ====================================================================
    *
  @@ -96,7 +96,7 @@
    * synchronization is performed around accesses to the principals collection.
    *
    * @author Craig R. McClanahan
  - * @version $Revision: 1.7 $ $Date: 2000/07/26 23:13:06 $
  + * @version $Revision: 1.8 $ $Date: 2000/07/27 01:27:20 $
    */
   
   public final class MemoryRealm
  @@ -342,6 +342,7 @@
   		break;
   	    String role = roles.substring(0, comma).trim();
   	    principal.addRole(role);
  +	    roles = roles.substring(comma + 1);
   	}
   
       }
  
  
  

Mime
View raw message