tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From craig...@locus.apache.org
Subject cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/servlets DefaultErrorPage.java
Date Wed, 26 Apr 2000 17:24:06 GMT
craigmcc    00/04/26 10:24:06

  Modified:    src/share/org/apache/tomcat/core
                        BufferedServletOutputStream.java
               src/share/org/apache/tomcat/servlets DefaultErrorPage.java
  Log:
  Add a flush() in two places to the DefaultErrorPage servlet, to avoid
  potential hang problems on IE due to the fact that the content length was
  getting set.
  
  IMHO it should never be necessary for a servlet to call flush on the
  output stream or writer -- that should be the container's responsibility.
  But this fix doesn't hurt anything.  Further investigation is appropriate.
  
  Thanks for the investigation and the patch!
  
  PR: 284
  Submitted by:	carsonm@missiondata.com
  
  Revision  Changes    Path
  1.11      +3 -4      jakarta-tomcat/src/share/org/apache/tomcat/core/BufferedServletOutputStream.java
  
  Index: BufferedServletOutputStream.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/BufferedServletOutputStream.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- BufferedServletOutputStream.java	2000/03/21 19:19:39	1.10
  +++ BufferedServletOutputStream.java	2000/04/26 17:24:05	1.11
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/BufferedServletOutputStream.java,v
1.10 2000/03/21 19:19:39 costin Exp $
  - * $Revision: 1.10 $
  - * $Date: 2000/03/21 19:19:39 $
  + * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/BufferedServletOutputStream.java,v
1.11 2000/04/26 17:24:05 craigmcc Exp $
  + * $Revision: 1.11 $
  + * $Date: 2000/04/26 17:24:05 $
    *
    * ====================================================================
    * 
  @@ -315,4 +315,3 @@
       }
   
   }
  -
  
  
  
  1.10      +2 -0      jakarta-tomcat/src/share/org/apache/tomcat/servlets/DefaultErrorPage.java
  
  Index: DefaultErrorPage.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/servlets/DefaultErrorPage.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- DefaultErrorPage.java	2000/04/13 01:45:56	1.9
  +++ DefaultErrorPage.java	2000/04/26 17:24:05	1.10
  @@ -157,9 +157,11 @@
   	if( response.isUsingStream() ) {
   	    ServletOutputStream out = response.getOutputStream();
   	    out.print(body);
  +	    out.flush();
   	} else {
   	    PrintWriter out = response.getWriter();
   	    out.print(body);
  +	    out.flush();
   	}
       }
   
  
  
  

Mime
View raw message