tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cos...@costin.dnt.ro>
Subject Re: [PATCH] Remove HTTPServer
Date Mon, 24 Jan 2000 15:06:27 GMT
Conor MacNeill wrote:

> - Changes the server.xml syntax. It removes the port, hostname, etc from the
> context manager
> - Adds the concept of named context managers to distinguish multiple context
> managers and their work areas.
> - Introduces a new class, TomcatServer, to hold multiple contextManagers
> (this is a replacement for one of HttpServer's nominal functions)
> - Fixes SimpleStartup.java to use ContextManager rather than HttpServer
> which didn't work anyway.

Hi Conor,

Please give me one more week to review the changes, most of them are fine,
but I want to spend some more time with few of them.

I'm not sure it's a good ideea to add TomcatServer - most of the time we
have only one ContextManager ( in fact this may be a singleton !), and
right now I prefer removing and not adding :-)

SimpleStartup and everything else are fine using just ContextManager, and
I think we are better without it.

> There is more to come (connector updates, define some constants, cleanup,
> javadocs) but this patch is pretty big already. In particular I need to work
> out the new tomcat.xml/Tomcat.java/XmlHelper stuff to adjust it correctly. I
> have probably broken that part for now but the main tests and watchdog seem
> to pass OK (I get some errors under watchdog but these are the same as
> before this patch :-)

Tomcat.java, XmlHelper are changing ( I'm working on them ), please wait
until they stabilize a bit.

Sorry if I'm too slow, but everything is moving very fast and I still have some

items I want to do.

Costin


Mime
View raw message