tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Conor MacNeill" <co...@m64.com>
Subject [PATCH] Remove HTTPServer
Date Mon, 24 Jan 2000 13:02:23 GMT
Hi,

This is a major patch. It is a result of the discussion Costin and I had
about the role of the HttpServer class. The patch achieves a number of
things

- Deletes HttpServer.java, HttpServerException.java and HttpAdapter.java.
These are no longer required since HTTP operation is just another type of
connector - nothing special.
- Defines a new exception, TomcatException, to be used for general Tomcat
exception conditions. Some of the "throws Exception" usage is replaced with
"throws TomcatException"
- Removes the address, port and hostname attributes from contextManager.
These are properties which should be supplied by the connector over which
the connection is made.
- Changes the server.xml syntax. It removes the port, hostname, etc from the
context manager
- Adds the concept of named context managers to distinguish multiple context
managers and their work areas.
- Introduces a new class, TomcatServer, to hold multiple contextManagers
(this is a replacement for one of HttpServer's nominal functions)
- Fixes SimpleStartup.java to use ContextManager rather than HttpServer
which didn't work anyway.


There is more to come (connector updates, define some constants, cleanup,
javadocs) but this patch is pretty big already. In particular I need to work
out the new tomcat.xml/Tomcat.java/XmlHelper stuff to adjust it correctly. I
have probably broken that part for now but the main tests and watchdog seem
to pass OK (I get some errors under watchdog but these are the same as
before this patch :-)

I'm including the diffs and the new files as attachments rather than just
cutting and pasting into this message as I think that will be clearer.

Let me know if you have any comments.


Cheers
Conor

Mime
View raw message