Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
From: "Conor MacNeill" <conor@m64.com>
To: <tomcat-dev@jakarta.apache.org>
Subject: RE: Ant build broken + Shell issues
Date: Tue, 7 Dec 1999 01:12:02 +1100
Message-ID: <001f01bf3ff3$de236e50$80dc1fcb@cognetnt.cognet.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Importance: Normal
In-Reply-To: <384A7DC0.4C47F060@eng.sun.com>

> Hi,
>
> There are few problems :-)

I can give a few more for trying to bootstrap ant on NT. (I wonder why there
is no bootstrap.sh file for Unix?)

There is the continuing problem of classpaths which contain spaces causing
boostrap.bat to misbehave. For every usage of %C% in a -classpath option, it
should be quoted "%C%"

The bootstrap fails because it cannot find the parser.properties file. I
guess this is because it is not copied over to the tmp directory during the
bootstrap. Adding the following line

%COPYCMD% src\main\org\apache\tools\ant\parser.properties
%TMPDIR%\org\apache\tools\ant

will fix that. Then the default manifest file cannot be found. Adding

%COPYCMD% src\main\org\apache\tools\ant\defaultManifest.mf
%TMPDIR%\org\apache\tools\ant

will fix that.

Once the properties file is found, it points to a parser which doesn't exist

	parser=org.apache.tools.ant.parsers.SunParser.

Changing that to

	parser=org.apache.tools.ant.SunParser

fixes things.


Finally the bootstrap fails because the chmod taskdef only works on Unix at
the moment. In fact the ant build.xml file seems to have become quite a bit
more Unix specific recently; the package.dir value "/home/ftp/pub/tomcat"
will fail on most NT systems. Also, I would prefer to see ${dist.dir} be a
dist directory created as part of the build (similar to the build directory
and similar to the tomcat build.xml file). I'm not sure of the motivation
behind ${user.home}/opt as the ${dist.dir} value. Finally the build.xml file
will create a Unix shell script in {my NT "home" directory}/opt/ant/bin. I'm
not sure how desirable that is.

In general, I feel that OS specific stuff should perhaps be moved from the
build.xml files to the build.bat and build.sh files. These scripts could
pick up stuff from the "dist" directory created by ant and place it in OS
appropriate locations.

What do you think?

Cheers
Conor

Below are the diffs for my ant area

Index: bootstrap.bat
===================================================================
RCS file: /home/cvspublic/jakarta-tools/ant/bootstrap.bat,v
retrieving revision 1.2
diff -r1.2 bootstrap.bat
22c22
< javac -classpath %C% -d %TMPDIR% %SRCDIR%\*.java
---
> javac -classpath "%C%" -d %TMPDIR% %SRCDIR%\*.java
28c28
< javac -classpath %C% -d %TMPDIR% %SRCDIR%\taskdefs\*.java
---
> javac -classpath "%C%" -d %TMPDIR% %SRCDIR%\taskdefs\*.java
34a35,36
> %COPYCMD% src\main\org\apache\tools\ant\parser.properties
%TMPDIR%\org\apache\tools\ant
> %COPYCMD% src\main\org\apache\tools\ant\defaultManifest.mf
%TMPDIR%\org\apache\tools\ant
39c41
< java -classpath %C% org.apache.tools.ant.Main dist %1 %2 %3 %4 %5
---
> java -classpath "%C%" org.apache.tools.ant.Main dist %1 %2 %3 %4 %5
43c45
< java -classpath %C% org.apache.tools.ant.Main clean %1 %2 %3 %4 %5
---
> java -classpath "%C%" org.apache.tools.ant.Main clean %1 %2 %3 %4 %5

Index: build.bat
===================================================================
RCS file: /home/cvspublic/jakarta-tools/ant/build.bat,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 build.bat
3c3
< java -classpath ..\ant.jar;..\projectx-tr2.jar;%CLASSPATH%
org.apache.tools.ant.Main %1 %2 %3 %4 %5
\ No newline at end of file
---
> java -classpath "..\ant.jar;..\projectx-tr2.jar;%CLASSPATH%"
org.apache.tools.ant.Main %1 %2 %3 %4 %5
\ No newline at end of file

Index: src/main/org/apache/tools/ant/parser.properties
===================================================================
RCS file:
/home/cvspublic/jakarta-tools/ant/src/main/org/apache/tools/ant/parser.prope
rties,v
retrieving revision 1.1
diff -r1.1 parser.properties
1c1
< parser=org.apache.tools.ant.parsers.SunParser
\ No newline at end of file
---
> parser=org.apache.tools.ant.SunParser
\ No newline at end of file

--
Conor MacNeill
conor@m64.com
M64 Pty Limited