tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefano Mazzocchi <stef...@apache.org>
Subject Re: cvs commit: jakarta-tools/ant/src/main/org/apache/tools/ant/taskdefs Javac.java
Date Thu, 25 Nov 1999 13:27:22 GMT
"Preston L. Bannister" wrote:
> 
> From: James Duncan Davidson [mailto:james.davidson@eng.sun.com]
> >
> > jons@hyperreal.org wrote:
> [snip]
> > >   RCS file: /home/cvs/jakarta-tools/ant/src/main/org/apache/tools/ant/taskdefs/Javac.java,v
> > >   diff -u -r1.11 -r1.12
> > >   --- Javac.java        1999/11/23 21:54:47     1.11
> > >   +++ Javac.java        1999/11/24 18:45:59     1.12
> > >   @@ -306,7 +306,8 @@
> > >         // add our classpath to the mix
> > >
> > >         if (compileClasspath != null) {
> > >   -         StringTokenizer tok = new StringTokenizer(compileClasspath, ":",
> > >   +         StringTokenizer tok = new StringTokenizer(compileClasspath,
> > >   +            File.pathSeparator,
> >
> > Actually, dont do this... I haven't yet written up how the format of the
> > build.xml files should be, but we need a "standard" path and file
> > seperator in use there that gets translated to native system path
> > seperator. That's the whole point of parsing here on the ":". If you run
> > this now on another system, you wont' get valid parsing behavior.
> 
> You do realize that ":" is an in-path character on Win32?

I was thinking the exact same thing.
 
> For example:
> 
> CLASSPATH=.;C:\VisualCafePDE\BIN\COMPONENTS\SYMBEANS.JAR;C:\VisualCafePDE\JAVA\LIB\CLASSES.ZIP;C:\VisualCafePDE\JAVA\LIB
> 
> Which is why ";" is used on Win32.

Right.

Why don't we use nice simple commas instead? we do this in jserv and
nobody ever complained.

 classpath="c:\java\code , /usr/local/bin ,
whatever#platform#comes#next"
 
-- 
Stefano Mazzocchi      One must still have chaos in oneself to be
                          able to give birth to a dancing star.
<stefano@apache.org>                             Friedrich Nietzsche



Mime
View raw message