Return-Path: Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 4482 invoked from network); 18 Oct 1999 17:02:07 -0000 Received: from mercury.sun.com (192.9.25.1) by apache.org with SMTP; 18 Oct 1999 17:02:07 -0000 Received: from engmail4.Eng.Sun.COM ([129.144.134.6]) by mercury.Sun.COM (8.9.3+Sun/8.9.3) with ESMTP id KAA13546 for ; Mon, 18 Oct 1999 10:02:06 -0700 (PDT) Received: from pathfinder.eng.sun.com (pathfinder.Eng.Sun.COM [129.144.251.57]) by engmail4.Eng.Sun.COM (8.9.1b+Sun/8.9.1/ENSMAIL,v1.6) with ESMTP id KAA27028 for ; Mon, 18 Oct 1999 10:02:05 -0700 (PDT) Received: from pathfinder (pathfinder [129.144.251.57]) by pathfinder.eng.sun.com (8.8.8+Sun/8.8.8) with SMTP id KAA17655 for ; Mon, 18 Oct 1999 10:02:01 -0700 (PDT) Message-Id: <199910181702.KAA17655@pathfinder.eng.sun.com> Date: Mon, 18 Oct 1999 10:02:01 -0700 (PDT) From: Mandar Raje Reply-To: Mandar Raje Subject: Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compilerIncludeGenerator.java To: tomcat-dev@jakarta.apache.org MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Content-MD5: yOIM6DM7LFvRqdDiEWsIbw== X-Mailer: dtmail 1.2.1 CDE Version 1.2.1 SunOS 5.6 sun4u sparc Thanks Danno for pointing it out. I will make the necessary changes. Mandar. > > > > > mandar 99/10/17 11:40:07 > > > > Modified: src/share/org/apache/jasper/compiler IncludeGenerator.java > > Log: > > spec compliance: > > > > params in jsp:include to be taken out after return from the include. > > > > Shouldn't the old values be stored and then restored insted of deleted? > This code will not only allow the new value to over-writer the older value, > but then all reace of it is gone. I haven't spent much time looking at it > and it doesn't seem to be there, but couldn't the old attributes hashtable > be cloned and pushed off so that when the include returned it could be poped > back on? Honestly I could counjure up some degenerate and not so degenerate > cases where this could come into play. > > ... > > > @@ -148,6 +148,15 @@ > > writer.println ("pageContext.include(" + > > JspUtil.getExpr(page) + > > ");"); > > - > > + > > + // Now remove the parameters that were meant only for the inclusion. > > + if (params.size() > 0) { > > + Enumeration en = params.keys(); > > + while (en.hasMoreElements()) { > > + String key = (String) en.nextElement(); > > + writer.println("request.removeAttribute(\"" + key + "\");"); > > + } > > + } > > + > > } > > } > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org >