tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig McClanahan" <cmcclana...@mytownnet.com>
Subject Re: cvs commit:jakarta-tomcat/src/share/org/apache/jasper/compilerIncludeGenerator.java
Date Mon, 18 Oct 1999 15:40:51 GMT
Danno Ferrin wrote:

> > mandar      99/10/17 11:40:07
> >
> >   Modified:    src/share/org/apache/jasper/compiler IncludeGenerator.java
> >   Log:
> >   spec compliance:
> >
> >    params in jsp:include to be taken out after return from the include.
> >
>
> Shouldn't the old values be stored and then restored insted of deleted?
> This code will not only allow the new value to over-writer the older value,
> but then all reace of it is gone.  I haven't spent much time looking at it
> and it doesn't seem to be there, but couldn't the old attributes hashtable
> be cloned and pushed off so that when the include returned it could be poped
> back on?  Honestly I could counjure up some degenerate and not so degenerate
> cases where this could come into play.
>

One not-so-degenerate case is nested includes.  If I'm reading the code change
correctly, in the scenario "A includes B, which includes C", the B page can see
the special attributes up to the point where it includes C, but after that it
cannot.

Craig McClanahan



Mime
View raw message