tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mandar Raje <man...@pathfinder.eng.sun.com>
Subject Re: cvs commit: jakarta-tomcat/src/share/org/apache/jasper/compilerIncludeGenerator.java
Date Mon, 18 Oct 1999 17:02:01 GMT

Thanks Danno for pointing it out. I will make the necessary changes.

Mandar.

> 
> 
> 
> > mandar      99/10/17 11:40:07
> >
> >   Modified:    src/share/org/apache/jasper/compiler IncludeGenerator.java
> >   Log:
> >   spec compliance:
> >
> >    params in jsp:include to be taken out after return from the include.
> >
> 
> Shouldn't the old values be stored and then restored insted of deleted?
> This code will not only allow the new value to over-writer the older value,
> but then all reace of it is gone.  I haven't spent much time looking at it
> and it doesn't seem to be there, but couldn't the old attributes hashtable
> be cloned and pushed off so that when the include returned it could be poped
> back on?  Honestly I could counjure up some degenerate and not so degenerate
> cases where this could come into play.
> 
> ...
> 
> >   @@ -148,6 +148,15 @@
> >        writer.println ("pageContext.include(" +
> >        JspUtil.getExpr(page) +
> >        ");");
> >   -
> >   +
> >   + // Now remove the parameters that were meant only for the inclusion.
> >   + if (params.size() > 0) {
> >   +     Enumeration en = params.keys();
> >   +     while (en.hasMoreElements()) {
> >   + String key = (String) en.nextElement();
> >   + writer.println("request.removeAttribute(\"" + key + "\");");
> >   +     }
> >   + }
> >   +
> >        }
> >    }
> >
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
> 


Mime
View raw message