tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1990) Add a shortestPath() step
Date Thu, 02 Aug 2018 11:27:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566649#comment-16566649
] 

ASF GitHub Bot commented on TINKERPOP-1990:
-------------------------------------------

Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/882#discussion_r207191097
  
    --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Traversal.java
---
    @@ -496,15 +496,17 @@ public default void reset() {
             public void setGraph(final Graph graph);
     
             public default boolean equals(final Traversal.Admin<S, E> other) {
    -            final List<Step> steps = this.getSteps();
    -            final List<Step> otherSteps = other.getSteps();
    -            if (steps.size() == otherSteps.size()) {
    -                for (int i = 0; i < steps.size(); i++) {
    -                    if (!steps.get(i).equals(otherSteps.get(i))) {
    -                        return false;
    +            if (this.getClass().equals(other.getClass())) {
    --- End diff --
    
    I guess this changes makes sense. Are you sure there was no reason why we didn't have
it that way to begin with? Just playing devil's advocate, but should `Traversal` equality
in some way be based on the steps the traversal contains rather than the class it has?


> Add a shortestPath() step
> -------------------------
>
>                 Key: TINKERPOP-1990
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1990
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>            Reporter: Daniel Kuppitz
>            Assignee: Daniel Kuppitz
>            Priority: Major
>
> Implement {{ShortestPathVertexProgram}} and a {{shortestPath()}} step.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message