tinkerpop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TINKERPOP-1550) Make Graphite and Ganglia optional dependencies
Date Thu, 15 Jun 2017 16:18:00 GMT

    [ https://issues.apache.org/jira/browse/TINKERPOP-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050701#comment-16050701
] 

ASF GitHub Bot commented on TINKERPOP-1550:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/628

    TINKERPOP-1550 Made ganglia/graphite optional dependencies

    https://issues.apache.org/jira/browse/TINKERPOP-1550
    
    These dependencies must now be installed manually by users. Updated docs and the LICENSE
for Gremlin Server. Gets rid of the weird one-off exclusion of an LGPL license (couldn't support
Ganglia out of the box anyway) and lessens transitive dependency burdens.
    
    Builds with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false
&& mvn verify -pl gremlin-console -DskipIntegrationTests=false`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1550

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #628
    
----
commit 945c23571fcccafb95f7c129d368955cd068c430
Author: Stephen Mallette <spmva@genoprime.com>
Date:   2017-06-15T16:11:51Z

    TINKERPOP-1550 Made ganglia/graphite optional dependencies
    
    These dependencies must now be installed manually by users. Updated docs and the LICENSE
for Gremlin Server.

----


> Make Graphite and Ganglia optional dependencies
> -----------------------------------------------
>
>                 Key: TINKERPOP-1550
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1550
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.3
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.3.0
>
>
> This ticket started out as "Provide a way to not specifically depend on and package the
various reporters tied to the Gremlin Server `MetricsManager`", but while that is a nice idea,
it ends up being more complicated than what is required and at this point I haven't really
heard of any users asking for the ability to drop in other reporters. 
> Anyway, Ganglia/Graphite should be made optional dependencies as they aren't really required
for operation of Gremlin Server and it should be up to the user to decide which they want
to use and include. Plus, this gets rid of the ugly problem of an LGPL dependency which we
used to just exclude and thus force the user to copy in manually. As a result, we kinda added
stuff to the distribution which didn't work out of the box anyway. Better to just avoid the
whole issue and not include them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message