tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] divijvaidya commented on pull request #1335: Tinkerpop-2426 Delegate WS internal handling to Netty
Date Thu, 01 Oct 2020 18:03:07 GMT

divijvaidya commented on pull request #1335:
URL: https://github.com/apache/tinkerpop/pull/1335#issuecomment-702304343


   > I didn't look at this in detail yet because gremlin-server integration tests are failing
in Travis. I've already restarted them once and they failed a second time.
   
   I have removed the test since it is not valid anymore. The test used to check if server
responded with a pong but now that logic is handled by Netty. If you feel strongly that we
should keep that test then we can add some logic to make the test work again but instead I
was planning to solve it separately by getting rid of our custom keep alive logic with Netty's
IdleHandler.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message