From commits-return-40520-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Fri Sep 4 00:54:20 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id C4B86180636 for ; Fri, 4 Sep 2020 02:54:20 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id F4192121C48 for ; Fri, 4 Sep 2020 00:54:19 +0000 (UTC) Received: (qmail 58103 invoked by uid 500); 4 Sep 2020 00:54:19 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 58094 invoked by uid 99); 4 Sep 2020 00:54:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Sep 2020 00:54:19 +0000 From: =?utf-8?q?GitBox?= To: commits@tinkerpop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Btinkerpop=5D_spmallette_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=231312=3A_Relax_access_for_class_members_and_add_get?= =?utf-8?q?ters/setters?= Message-ID: <159918085970.32230.7881574206682952978.asfpy@gitbox.apache.org> Date: Fri, 04 Sep 2020 00:54:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: spmallette commented on a change in pull request #1312: URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483327655 ########## File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversal.java ########## @@ -350,6 +351,10 @@ public void setGraph(final Graph graph) { this.graph = graph; } + public void setLocked(boolean locked) { Review comment: note that strategy application changed/improved on `master` for 3.5.0 already: https://tinkerpop.apache.org/docs/3.5.0-SNAPSHOT/upgrade/#_traversalstrategy_application looking forward to hearing what you think we might change but we will need to be careful not to introduce a change that inadvertently changes traversal behavior because we change strategy application order/approach. that's why we saved the above referenced change for 3.5.0. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org