tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] spmallette commented on a change in pull request #1312: Relax access for class members and add getters/setters
Date Fri, 04 Sep 2020 00:54:19 GMT

spmallette commented on a change in pull request #1312:
URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483327655



##########
File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversal.java
##########
@@ -350,6 +351,10 @@ public void setGraph(final Graph graph) {
         this.graph = graph;
     }
 
+    public void setLocked(boolean locked) {

Review comment:
       note that strategy application changed/improved on `master` for 3.5.0 already:
   
   https://tinkerpop.apache.org/docs/3.5.0-SNAPSHOT/upgrade/#_traversalstrategy_application
   
   looking forward to hearing what you think we might change but we will need to be careful
not to introduce a change that inadvertently changes traversal behavior because we change
strategy application order/approach. that's why we saved the above referenced change for 3.5.0.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message