tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1312: Make TinkerVertex non-final
Date Thu, 03 Sep 2020 22:02:05 GMT

divijvaidya commented on a change in pull request #1312:
URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483277388



##########
File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversal.java
##########
@@ -350,6 +351,10 @@ public void setGraph(final Graph graph) {
         this.graph = graph;
     }
 
+    public void setLocked(boolean locked) {

Review comment:
       It's a separate conversation. I will soon raise a PR for that. I think that the way
in which we apply strategies (first to all steps and then to each children one at a time),
could be improved to apply all strategies at the same time to the entire traversal and sub-traversal.
I will remove this change from this PR, pending further discussion on a new PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message