tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] heljoyLiu commented on issue #1275: gremlin-javascript: remove session close method
Date Fri, 03 Apr 2020 01:41:45 GMT
heljoyLiu commented on issue #1275: gremlin-javascript: remove session close method
URL: https://github.com/apache/tinkerpop/pull/1275#issuecomment-608182269
 
 
   
   > @heljoyLiu i think you follow what needs to happen now. do not worry about `master`.
if you could please make sure that `3.3-dev` and `3.4-dev` send the "close" message for all
languages and that the "close" message does not have the "gremlin" argument. let's get that
much correct before we worry about anything else. thank you.
   
   ok, until now, follow works for me:
   1. make sure that `3.3-dev` and `3.4-dev` send the "close" message for all languages
   2. the "close" message does not have the "gremlin" argument
   
   and more detail:
   1. remove "gremlin" argument of javascript on `3.3-dev`
   2. add the session "close" request for .Net SDK on `3.4-dev`
   3. re-target session PR with session "close" request for python on `3.3.-dev`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message