tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] heljoyLiu commented on issue #1275: gremlin-javascript: remove session close method
Date Thu, 02 Apr 2020 13:00:55 GMT
heljoyLiu commented on issue #1275: gremlin-javascript: remove session close method
URL: https://github.com/apache/tinkerpop/pull/1275#issuecomment-607831792
 
 
   > I think there might be some confusion. For `3.3-dev` you were just going to remove
this:
   > 
   > ```js
   > const args = {'gremlin': 'session.close()'};
   > ```
   > 
   
   this is only tips or debug message, server do not care that also, I don't pay attention
on "gremlin" section. 
   So it means remove unnecessary section, and send request word by word. I'm aware of it
now.
   
   
   > This PR that removes the sending of the "close" message should be targeted at the
`master` branch. It is on the `master` branch that the Java driver no longer supports sending
it and we want to match that functionality there.
   
   To the end, `3.3-dev` still remain "close" request of session in client, but `master` and
`3.4-dev` target to remove this request.
   
   sorry for this, so now I only remove the "gremlin" section in close request,  and this
PR will re-target to `3.4-dev`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message