tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] jorgebay commented on a change in pull request #1273: TINKERPOP-2349 Migrate JSON serialization to System.Text.Json in Gremlin.NET
Date Wed, 01 Apr 2020 10:55:12 GMT
jorgebay commented on a change in pull request #1273: TINKERPOP-2349 Migrate JSON serialization
to System.Text.Json in Gremlin.NET
URL: https://github.com/apache/tinkerpop/pull/1273#discussion_r401525494
 
 

 ##########
 File path: gremlin-dotnet/glv/Gremlin.Net.csproj.template
 ##########
 @@ -19,7 +19,7 @@ limitations under the License.
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup Label="Build">
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>netstandard2.0;netcoreapp3.0</TargetFrameworks>
 
 Review comment:
   I think there's no need to add `netcoreapp3.0` as a target for the core project, given
that `netcoreapp3.0` implements `netstandard2.0`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message