tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tinkerpop] spmallette commented on a change in pull request #1227: make Cluster be able to open file in classpath resource dir
Date Fri, 06 Dec 2019 11:48:27 GMT
spmallette commented on a change in pull request #1227: make Cluster be able to open file in
classpath resource dir
URL: https://github.com/apache/tinkerpop/pull/1227#discussion_r354795668
 
 

 ##########
 File path: gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java
 ##########
 @@ -244,9 +241,15 @@ public static Cluster open(final Configuration conf) {
      * Create a {@code Cluster} using a YAML-based configuration file.
 
 Review comment:
   Could you please expand the javadoc here to explain that the method will first try to read
the file from the file system and then from resources?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message