From commits-return-37882-apmail-tinkerpop-commits-archive=tinkerpop.apache.org@tinkerpop.apache.org Thu Oct 3 16:41:40 2019 Return-Path: X-Original-To: apmail-tinkerpop-commits-archive@minotaur.apache.org Delivered-To: apmail-tinkerpop-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id D5E0D1993E for ; Thu, 3 Oct 2019 16:41:39 +0000 (UTC) Received: (qmail 30843 invoked by uid 500); 3 Oct 2019 16:41:39 -0000 Delivered-To: apmail-tinkerpop-commits-archive@tinkerpop.apache.org Received: (qmail 30815 invoked by uid 500); 3 Oct 2019 16:41:39 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 30750 invoked by uid 99); 3 Oct 2019 16:41:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Oct 2019 16:41:39 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 183E0890A6; Thu, 3 Oct 2019 16:41:39 +0000 (UTC) Date: Thu, 03 Oct 2019 16:41:41 +0000 To: "commits@tinkerpop.apache.org" Subject: [tinkerpop] 04/06: TINKERPOP-2076 Made expectations around mock more explicit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: spmallette@apache.org In-Reply-To: <157012089786.14490.17958673177692476185@gitbox.apache.org> References: <157012089786.14490.17958673177692476185@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: tinkerpop X-Git-Refname: refs/heads/TINKERPOP-2076 X-Git-Reftype: branch X-Git-Rev: fd85f600a8ff9fa90146387ac727d5d882ed7ed7 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20191003164139.183E0890A6@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch TINKERPOP-2076 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit fd85f600a8ff9fa90146387ac727d5d882ed7ed7 Author: Stephen Mallette AuthorDate: Wed Mar 6 14:56:17 2019 -0500 TINKERPOP-2076 Made expectations around mock more explicit The upgrade of mockito must have tightened some requirements around stubbing and the use of nulls. Setting expected arguments seemed to get the test working as it was before. --- .../tinkerpop/gremlin/server/op/AbstractEvalOpProcessorTest.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessorTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessorTest.java index 88d12ea..657cfb2 100644 --- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessorTest.java +++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessorTest.java @@ -19,6 +19,7 @@ package org.apache.tinkerpop.gremlin.server.op; import io.netty.channel.ChannelHandlerContext; +import org.apache.tinkerpop.gremlin.driver.Tokens; import org.apache.tinkerpop.gremlin.driver.message.RequestMessage; import org.apache.tinkerpop.gremlin.driver.message.ResponseMessage; import org.apache.tinkerpop.gremlin.driver.message.ResponseStatusCode; @@ -41,11 +42,13 @@ import static org.mockito.Matchers.anyString; public class AbstractEvalOpProcessorTest { - @org.junit.Ignore @Test public void evalOpInternalShouldHandleAllEvaluationExceptions() throws OpProcessorException { final AbstractEvalOpProcessor processor = new StandardOpProcessor(); - final RequestMessage request = RequestMessage.build("test").create(); + final RequestMessage request = RequestMessage.build("test") + .addArg(Tokens.ARGS_GREMLIN, "1+1") + .addArg(Tokens.ARGS_LANGUAGE, "gremlin-groovy") + .create(); final Settings settings = new Settings(); final ChannelHandlerContext ctx = Mockito.mock(ChannelHandlerContext.class); final ArgumentCaptor responseCaptor = ArgumentCaptor.forClass(ResponseMessage.class);