tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] spmallette commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates
Date Fri, 18 Jan 2019 13:05:49 GMT
spmallette commented on issue #1042: TINKERPOP-2133 Implement index lookup for Text predicates
URL: https://github.com/apache/tinkerpop/pull/1042#issuecomment-455539530
 
 
   thanks for orchestrating this pull request as i know you likely needed changes from neo4j-contrib.
i think it's ok to bump to this new version of neo4j for TinkerPop 3.4.1 but since it's a
major dependency change I will[ email the dev list](https://lists.apache.org/thread.html/7e96fee99fe6ce2539819f153d5841a670d0abd07fd12084a8fa566a@%3Cdev.tinkerpop.apache.org%3E)
to see if there are any objections to doing so. 
   
   A few issues:
   
   1. There are dependency conflicts being reported during the build by the enforcer plugin.
Those will need to be resolved. Note that you might not have noticed them if you built with
just `mvn clean install`. We don't automatically run the full tests for neo4j for a number
of reasons, so you need to do `mvn clean install -DincludeNeo4j` - in case you're interested
you can find a lot of this kind of information in our [developer documentation](http://tinkerpop.apache.org/docs/current/dev/developer/#building-testing).
   2.  is there any reason you didn't also modify `MultiMetaNeo4jTrait`? 
   3.  are there tests that validate these changes somehow? There are `TextP` tests in the
`HastTest` suite of `gremlin-test` but does anything in neo4j need to be configured for the
string matching to work?
   4. I think this is a big enough change that we need some upgrade documentation. You can
add that [here](https://github.com/apache/tinkerpop/blob/master/docs/src/upgrade/release-3.4.x.asciidoc#tinkerpop-341)
- that pattern we use should be easy enough to follow to add a new section. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message