tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] spmallette commented on issue #1029: Updates the API within the core project.
Date Thu, 17 Jan 2019 12:08:54 GMT
spmallette commented on issue #1029: Updates the API within the core project.
URL: https://github.com/apache/tinkerpop/pull/1029#issuecomment-455150094
 
 
   I hate to be a bother but our git workflow goes from `tp33 --> master`. we typically
don't make it a habit of cherrypicking commits backwards in the flow as it makes the git history
messy. 
   
   i'd much prefer a rebase on tp33 with a squash of all these commits into one. we can then
merge forward to master. if you need to apply additional changes on master as they only apply
there then that can come as a separate PR. In general, it's best to always target tp33 with
your PRs unless there is explicit reason not to. If you ever have doubts on what branch to
target, feel free to ask ahead of time. 
   sorry for the hassle and thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message