tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nivsherf commented on a change in pull request #1038: TINKERPOP-2130 Fix default parameter assignment in Connection ctor
Date Mon, 14 Jan 2019 19:57:46 GMT
nivsherf commented on a change in pull request #1038: TINKERPOP-2130 Fix default parameter
assignment in Connection ctor
URL: https://github.com/apache/tinkerpop/pull/1038#discussion_r247636497
 
 

 ##########
 File path: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
 ##########
 @@ -69,8 +69,9 @@ class Connection extends EventEmitter {
   constructor(url, options) {
     super();
 
+    options = options || {};
 
 Review comment:
   Makes sense @jorgebay. I updated the code accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message