tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dkuppitz opened a new pull request #1035: TINKERPOP-2126 Made TraverserSet internals thread-safe
Date Wed, 09 Jan 2019 15:08:58 GMT
dkuppitz opened a new pull request #1035: TINKERPOP-2126 Made TraverserSet internals thread-safe
URL: https://github.com/apache/tinkerpop/pull/1035
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2126
   
   This PR replaces the `LinkedHashMap` used by `TraverserSet` with a `SynchronizedMap`. I
haven't added a test case, cause I really don't know how to consistently provoke a `ConcurrentModificationException`;
however, a `ConcurrentModificationException` did happen several times in a provider implementation
and it was caused by the `TraverserSet::toString()` method while Spark was a) processing a
query and b) concurrently logging the current state. The way `TraverserSet::toString()` is
implemented, it totally makes sense that this scenario would sooner or later hit a `ConcurrentModificationException`
if we don't use a synchronized map.
   
   `docker/build.sh -t -i` passed.
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message