tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] FlorianHockmann opened a new pull request #1025: TINKERPOP-2119 Add C# code examples in doc as code
Date Wed, 26 Dec 2018 16:32:03 GMT
FlorianHockmann opened a new pull request #1025: TINKERPOP-2119 Add C# code examples in doc
as code
URL: https://github.com/apache/tinkerpop/pull/1025
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2119
   
   I moved most of the code examples from the docs into C# source files from where they are
now included in the docs. The examples are mostly added as tests. Although I had to disable
(`skip`) most of these tests for now as they try to connect to a server running on `localhost:8182`
where no server is listening in our test environment. Nevertheless, this ensures even for
these disabled tests that the example code at least compiles and I could already find some
more errors in these examples.
   
   We should from now one only add C# code examples to the docs by adding them as source code
and then including them in the AsciiDoc to ensure that our examples in the docs always work
and always match their respective version of Gremlin.Net.
   
   Only one C# code listing is still left directly in the docs as it includes numbers as references
which are then referenced in the text below (for the lambda solution). We could of course
replace these numbers simply by line numbers, but I didn't want to do that for just one example
as it would break the style of the other examples.
   
   I verified that the changes in the docs look as expected manually after generating the
docs with `docker/build.sh -d` and the .NET tests all pass.
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message